small etherdevice.h fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

This fixes a small bug in is_valid_ether_addr --- for address in the form FF:xx:xx:xx:xx:xx it returns true. The comment is about FF:FF:FF:FF:FF:FF is not true, is_multicast_ether_addr doesn't accept FF:FF:FF:FF:FF:FF as multicast (as you can see few lines above).
Mikulas

--- include/linux/etherdevice.h_	2006-02-03 21:05:23.000000000 +0100
+++ include/linux/etherdevice.h	2006-02-03 21:05:59.000000000 +0100
@@ -91,9 +91,7 @@
  */
 static inline int is_valid_ether_addr(const u8 *addr)
 {
-	/* FF:FF:FF:FF:FF:FF is a multicast address so we don't need to
-	 * explicitly check for it here. */
-	return !is_multicast_ether_addr(addr) && !is_zero_ether_addr(addr);
+	return !(addr[0] & 1) && !is_zero_ether_addr(addr);
 }

 /**
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux