Re: [PATCH] Remove gfp argument from kstrdup()

On Fri, 2006-01-06 at 14:15 +0200, Timo Hirvonen wrote:
> On Fri, 6 Jan 2006 13:51:41 +0200
> Pekka Enberg <[email protected]> wrote:
> 
> > On 1/5/06, Timo Hirvonen <[email protected]> wrote:
> > > All kstrdup() callers use GFP_KERNEL flag so this parameter seems to be
> > > useless.
> > 
> > Please don't. You're making the API inconsistent and forcing everyone
> > to use GFP_KERNEL for little or no benefit.
> 
> I don't see why any other GFP_* flag could be useful for strings.

I think you missed the point a bit..
the GFP_ flags aren't so much about what you allocate it, but in what
circumstances you are allocating (eg inside a lock/irq or not etc)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Remove gfp argument from kstrdup()
    • From: Timo Hirvonen <[email protected]>
  • Re: [PATCH] Remove gfp argument from kstrdup()
    • From: Pekka Enberg <[email protected]>
  • Re: [PATCH] Remove gfp argument from kstrdup()
    • From: Timo Hirvonen <[email protected]>

• Prev by Date: Re: [PATCH] Remove gfp argument from kstrdup()
• Next by Date: Re: State of the Union: Wireless
• Previous by thread: Re: [PATCH] Remove gfp argument from kstrdup()
• Next by thread: [PATCH 3/4] UML - Merge trap_user.c and trap_kern.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]