Re: [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with 0

On Thu, 5 Jan 2006, Chris Wright wrote:
> 
> If the string was too long to fit in the user-supplied buffer,
> the sysctl layer would zero-terminate it by writing past the
> end of the buffer. Don't do that.

Don't use this one. It doesn't zero-pad the string if the result buffer is 
too small (which _could_ cause problems) and it actually returns the wrong 
length too. 

There's a better one in the final 2.6.15.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH, RFC] RCU : OOM avoidance and lower latency
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with 0
    • From: Chris Wright <[email protected]>

• References:
  • [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with 0
    • From: Chris Wright <[email protected]>

• Prev by Date: Re: [OT] ALSA userspace API complexity
• Next by Date: Re: 80 column line limit?
• Previous by thread: [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with 0
• Next by thread: Re: [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with 0
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]