Re: [PATCH] Fix user data corrupted by old value return of sysctl

2005/12/31, Yi Yang <[email protected]>:
> Coywolf Qi Hunt wrote:
> >You didn't set the trailing '\0', I wonder how your printf did work
> >properly ever. You've just been lucky or something.
> >
> >-- Coywolf
> >
> >
> The variable target does it, its value is 0x00000001, so you mustn't
> worry it.
> osname only has 4-bytes space, so if you set '\0' to its tail, a byte
> information will be lost.

I'm worrying more. We should set '\0'. Let the one byte information
lost, the caller deserve that. Actually here printf sees "mylo"+'\01'
if little endian.

Linus, besides fixing bug, your commit certainly breaks userland
compatibility. Please consider.
--
Coywolf Qi Hunt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix user data corrupted by old value return of sysctl
    • From: Yi Yang <[email protected]>
  • Re: [PATCH] Fix user data corrupted by old value return of sysctl
    • From: Coywolf Qi Hunt <[email protected]>
  • Re: [PATCH] Fix user data corrupted by old value return of sysctl
    • From: Yi Yang <[email protected]>

• Prev by Date: Re: [PATCH 14/14] page-replace-kswapd-incmin.patch
• Next by Date: Re: [PATCH 01/14] page-replace-single-batch-insert.patch
• Previous by thread: Re: [PATCH] Fix user data corrupted by old value return of sysctl
• Next by thread: Possible bug in amd64-agp (agpgart module)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]