Re: [PATCH 12 of 20] ipath - misc driver support code

On Fri, Dec 30, 2005 at 03:10:09PM -0800, Bryan O'Sullivan wrote:
> On Fri, 2005-12-30 at 00:25 -0800, Greg KH wrote:
> > > +	unsigned long long Control;
> > > +	unsigned long long PageAlign;
> > > +	unsigned long long PortCnt;
> > 
> > And what's with the InterCapsNamingScheme of these variables?
> 
> They're taken straight from the register names in our chip spec.  I can
> squish them to lowercase-only, if that seems important.

No, but document it that this is the reason for it (along with a pointer
to your chip spec, if possible.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • [PATCH 12 of 20] ipath - misc driver support code
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 12 of 20] ipath - misc driver support code
    • From: "Greg KH" <[email protected]>
  • Re: [PATCH 12 of 20] ipath - misc driver support code
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: Re: bad pmd filemap.c, oops; 2.4.30 and 2.4.32
• Next by Date: Re: [PATCH 8 of 20] ipath - core driver, part 1 of 4
• Previous by thread: Re: [PATCH 12 of 20] ipath - misc driver support code
• Next by thread: Re: [PATCH 12 of 20] ipath - misc driver support code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]