Re: [PATCH] protect remove_proc_entry

On Fri, 30 Dec 2005, Daniel Walker wrote:

> On Fri, 2005-12-30 at 16:28 -0500, Steven Rostedt wrote:
>
> > +	spin_lock_irqsave(&remove_proc_lock, flags);
> ...
> > +	spin_unlock_irqrestore(&remove_proc_lock, flags);
>
> Why do an irqsave here? Are you not sure what context it gets called
> from?
>

[snipped from original message]
"I'm not sure if remove_proc_entry is called from interrupt context, so I
did a irqsave just in case."

  ;-)

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Question] race condition with remove_proc_entry
    • From: Steven Rostedt <[email protected]>
  • [PATCH] protect remove_proc_entry
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH] protect remove_proc_entry
    • From: Daniel Walker <[email protected]>

• Prev by Date: Re: system keeps freezing once every 24 hours / random apps crashing
• Next by Date: Re: [PATCH] protect remove_proc_entry
• Previous by thread: Re: [PATCH] protect remove_proc_entry
• Next by thread: Re: [PATCH] protect remove_proc_entry
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]