Re: [rfc][patch] Avoid taking global tasklist_lock for single threadedprocess at getrusage()

On Wed, Dec 28, 2005 at 03:38:39PM +0300, Oleg Nesterov wrote:
> Christoph Lameter wrote:
> > 
> > On Sat, 24 Dec 2005, Oleg Nesterov wrote:
> > 
> > > I can't understand this. 'p' can do clone(CLONE_THREAD) immediately
> > > after 'if (!thread_group_empty(p))' check.
> > 
> > Only if p != current. As discussed later the lockless approach is
> > intened to only be used if p == current.
> 
> Unless I missed something this function (getrusage_both) is called
> from wait_noreap_copyout,

Hi Oleg,
Yes, this patch needs to be reworked.  I am on it.  I'd also missed that
p->signal was protected by the tasklist_lock.  Thanks for pointing it out.
I will put out the modified version soon.

Thanks,
Kiran
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [rfc][patch] Avoid taking global tasklist_lock for single threadedprocess at getrusage()
    • From: Ravikiran G Thirumalai <[email protected]>

• References:
  • Re: [rfc][patch] Avoid taking global tasklist_lock for single threaded process at getrusage()
    • From: Oleg Nesterov <[email protected]>
  • Re: [rfc][patch] Avoid taking global tasklist_lock for single threaded process at getrusage()
    • From: Christoph Lameter <[email protected]>
  • Re: [rfc][patch] Avoid taking global tasklist_lock for single threadedprocess at getrusage()
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: 2.6.15-rc7-rt1
• Next by Date: Re: [patch 01/2] allow gcc4 to control inlining
• Previous by thread: Re: [rfc][patch] Avoid taking global tasklist_lock for single threadedprocess at getrusage()
• Next by thread: Re: [rfc][patch] Avoid taking global tasklist_lock for single threadedprocess at getrusage()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]