On Wed, Dec 28, 2005 at 06:40:03AM -0800, Bryan O'Sullivan wrote:
> On Tue, 2005-12-27 at 17:10 -0800, Roland Dreier wrote:
>
> > I think the principle of least surprise calls for memcpy_toio32 to be
> > ordered the same way memcpy_toio is. In other words there should be a
> > wmb() after the loop.
>
> Will do.
>
> > Also, no need for the { } for the while loop.
>
> Fine. There doesn't seem to be much consistency in whether to use
> curlies for single-line blocks.
We've been very consistent in discouraging it in new code. Enforcement
of fine points of coding style is a post-2.5 phenomenon, so it hasn't
hit all the tree yet.
> > You're adding this symbol and exporting it even if the arch will
> > supply its own version. So this is pure kernel .text bloat...
>
> I don't know what you'd prefer, so let me enumerate a few alternatives,
> and you can either tell me which you'd prefer, or point out something
> I've missed that would be even better. I'm entirely flexible on this.
>
> * Use the __HAVE_ARCH_* mechanism that include/asm-*/string.h
> uses. Caveat: Linus has lately come out as hating this style.
> It makes for the smallest patch, though.
> * Define the generic code in lib/, and have each arch that really
> uses it export it.
I'd favor this, at least for this case. If it becomes more widely
used, we'll relocate the export.
> * Put generic code in include/asm-generic/algo-memcpy_toio32.h,
> and have each arch that needs it #include it somewhere and use
> it.
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
