Re: [PATCH 2 of 3] memcpy32 for x86_64

> > +
> > + 	.globl memcpy32
> > +memcpy32:
> > +	movl %edx,%ecx
> > +	shrl $1,%ecx
> > +	andl $1,%edx
> > +	rep
> > +	movsq

Does this one really do 32-bit stores?! I doubt so...

> > +	movl %edx,%ecx
> > +	rep
> > +	movsd
> > +	ret
> 
> Any reason this needs its own .S file? One wonders if the
> 
>         .p2align 4
> 
> in memcpy.S is appropriate here too. Splitting rep movsq across two
> lines is a little weird to me too, but I see Andi did it too.
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0 of 3] Add memcpy_toio32, a 32-bit MMIO copy routine
    • From: "Bryan O'Sullivan" <[email protected]>
  • [PATCH 2 of 3] memcpy32 for x86_64
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 2 of 3] memcpy32 for x86_64
    • From: Matt Mackall <[email protected]>

• Prev by Date: Re: [patch 1/3] mutex subsystem: trylock
• Next by Date: [RFC][fat] use mpage_readpage when cluster size is page-alignment
• Previous by thread: Re: [PATCH 2 of 3] memcpy32 for x86_64
• Next by thread: Re: [PATCH 2 of 3] memcpy32 for x86_64
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]