Re: [PATCH] forcedeth: fix random memory scribbling bug

Linus Torvalds wrote:

Of course, on the alloc path, it seems to add an additional "NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.

The problem is the pci_unmap_single() call that happens during nv_close() or the rx interrupt handler. I think it makes more sense to rely on fields in the individual skb instead of reading from np->rx_buf_sz. If np->rx_buf_sz changes inbetween, then we have a memory leak.

--
   Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] forcedeth: fix random memory scribbling bug
    • From: Linus Torvalds <[email protected]>

• References:
  • [PATCH] forcedeth: fix random memory scribbling bug
    • From: Manfred Spraul <[email protected]>
  • Re: [PATCH] forcedeth: fix random memory scribbling bug
    • From: Linus Torvalds <[email protected]>

• Prev by Date: Re: [PATCH] forcedeth: fix random memory scribbling bug
• Next by Date: Re: [PATCH] forcedeth: fix random memory scribbling bug
• Previous by thread: Re: [PATCH] forcedeth: fix random memory scribbling bug
• Next by thread: Re: [PATCH] forcedeth: fix random memory scribbling bug
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]