[PATCH] add missing memory barriers to ipc/sem.c

Hi Linus,

Two smp_wmb() statements are missing in the sysv sem code: This could cause stack corruptions.

The attached patch adds them.

Signed-Off-By: Manfred Spraul <[email protected]>

--- 2.6/ipc/sem.c	2005-12-19 01:36:54.000000000 +0100
+++ build-2.6/ipc/sem.c	2005-12-23 23:25:17.000000000 +0100
@@ -381,6 +381,7 @@
 			/* hands-off: q will disappear immediately after
 			 * writing q->status.
 			 */
+			smb_wmb();
 			q->status = error;
 			q = n;
 		} else {
@@ -461,6 +462,7 @@
 		n = q->next;
 		q->status = IN_WAKEUP;
 		wake_up_process(q->sleeper); /* doesn't sleep */
+		smp_wmb();
 		q->status = -EIDRM;	/* hands-off q */
 		q = n;
 	}

---

• Follow-Ups:
  • Re: [PATCH] add missing memory barriers to ipc/sem.c
    • From: Thomas Backlund <[email protected]>

• Prev by Date: [patch 09/19] [NETFILTER]: Fix NAT init order
• Next by Date: Re: [patch 18/19] SCSI: fix transfer direction in scsi_lib and st
• Previous by thread: [patch 00/19] -stable review for 2.6.14.5
• Next by thread: Re: [PATCH] add missing memory barriers to ipc/sem.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]