On Thu, Dec 22, 2005 at 06:42:26PM +0100, Karol Kozimor wrote: > Thus wrote Brown, Len: > > Karol, > > Do you have an update of your asus driver in the pipeline > > that addresses this? > > Here it goes. Rediffed, also plugs a leak my previous patch introduced. I > believe it addresses Linus' comments. It's still not a proper fix (see > below), but I believe it's better than none. > Best regards, This will break other hardware as the P30/P35 as well, since there are some buggy DSDT's out there that return an ACPI_TYPE_BUFFER. That's the whole reason why I was testing exactly for ACPI_TYPE_INTEGER in my patch. My first version was pretty simmilar to yours, until I was told on acpi-devel that this breaks someone elses hardware (causing it to be considered as P30/P35, while it isn't). I can dig up the mails if you want. Cheers, Christian
Attachment:
signature.asc
Description: Digital signature
- Follow-Ups:
- References:
- RE: asus_acpi still broken on Samsung P30/P35
- From: "Brown, Len" <[email protected]>
- [PATCH] Work around asus_acpi driver oopses on Samsung P30s and the like due to the ACPI implicit return
- From: Karol Kozimor <[email protected]>
- RE: asus_acpi still broken on Samsung P30/P35
- Prev by Date: Re: [RFC] genalloc != generic DEVICE memory allocator
- Next by Date: Re: 2.6.15-rc6: known regressions in the kernel Bugzilla
- Previous by thread: [PATCH] Work around asus_acpi driver oopses on Samsung P30s and the like due to the ACPI implicit return
- Next by thread: Re: [PATCH] Work around asus_acpi driver oopses on Samsung P30s and the like due to the ACPI implicit return
- Index(es):
 |