Re: [PATCH] pci device ensure sysdata initialised

On Thu, Dec 22, 2005 at 09:06:28PM +0000, Andy Whitcroft wrote:
> pci device ensure sysdata initialised
> 
> [Ok, here is a patch to ensure sysdata is valid for all busses.]
> 
> We have been seeing panic's on NUMA systems in pci_call_probe() in
> 2.6.15-rc5-mm2 and -mm3.  It seems that some changes have occured
> to the meaning of the 'sysdata' for a device such that it is no
> longer just an integer containing the node, it is now a structure
> containing the node and other data.  However, it seems that we do not
> always initialise this sysdata before we probe the device.

Yeah, but this patch is just papering over that fact :(

In fact, you will not put these devices on the proper node with this
patch, right?  So I don't think it is what you want.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] pci device ensure sysdata initialised
    • From: Andy Whitcroft <[email protected]>

• References:
  • Re: [PATCH] pci device sysdata may be null check in pcibus_to_node
    • From: Andrew Morton <[email protected]>
  • [PATCH] pci device ensure sysdata initialised
    • From: Andy Whitcroft <[email protected]>

• Prev by Date: Re: FW: Kernel oops v2.4.31 in e1000 network card driver.
• Next by Date: Re: nfs insecure_locks / Tru64 behaviour
• Previous by thread: [PATCH] pci device ensure sysdata initialised
• Next by thread: Re: [PATCH] pci device ensure sysdata initialised
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]