Re: [PATCH 2.6-git] SPI: add set_clock() to bitbang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Brownell wrote:

This is actually not needed.  Clocks are set through the setup() method
...

Where is it supposed to call setup? I guess it's anyway gonna be per-transfer, right?
Or am I missing something?

When the device is created, the core calls setup() to get things like
chipselect polarity sorted out and put into the inactive state.   That
matches the board-specific defaults associated with that device, which
would be a function of voltage, routing, and more.

And from then on, it'd be rare to ever call setup() again ... though
drivers certainly could do that between spi_message interactions with
a given device.
No, suppose there're two devices behind the same SPI bus that have different clock constraints. As active SPI device change may well happen when each new message is processed, we'll need to set up clocks again for each message. Right?

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux