On Thu, 22 Dec 2005 01:10:52 -0500, Dmitry Torokhov <[email protected]> wrote:
> On Tuesday 20 December 2005 17:15, Pete Zaitcev wrote:
> > Fedora users complain that passing "nousbstorage" to the installer causes
> > the rest of the USB support to disappear. The installer uses kernel command
> > line as a way to pass options through Syslinux. The problem stems from the
> > use of strncmp() in obsolete_checksetup().
> I wonder if that strncmp() should be changed into something like
> this (untested):
>
> --- work.orig/init/main.c
> +++ work/init/main.c
> @@ -167,7 +167,7 @@ static int __init obsolete_checksetup(ch
> p = __setup_start;
> do {
> int n = strlen(p->str);
> - if (!strncmp(line, p->str, n)) {
> + if (!strncmp(line, p->str, n) && !isalnum(line[n])) {
> if (p->early) {
Are you sure that your fix works well in case of __setup("foo=")?
It probably breaks all of those.
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
