On Wed, 2005-11-16 at 16:25 -0800, Andrew Morton wrote: > Trond Myklebust <[email protected]> wrote: > > > > The accompanying NFS patch makes use of this in order to figure out when > > to flush the data correctly. > > OK. So with that patch, nfs_writepages() may still leave I/O pending, > uninitiated, yes? > > I don't understand why NFS hasn't been BUGging as it stands at present. It > has several end_page_writeback() calls but no set_page_writeback()s. > end_page_writeback() or rotate_reclaimable_page() will go BUG if the page > wasn't PageWriteback(). It does have SetPageWriteback() calls in the asynchronous writeback path. As you can see from the patch I just sent, I only needed to replace them with set_page_writebacks(). Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- References:
- Re: mmap over nfs leads to excessive system load
- From: Kenny Simpson <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Trond Myklebust <[email protected]>
- Re: mmap over nfs leads to excessive system load
- From: Andrew Morton <[email protected]>
- Re: mmap over nfs leads to excessive system load
- Prev by Date: [PATCH] preserve irq status in release_pages(), __pagevec_lru_add() and __pagevec_lru_active()
- Next by Date: Re: [2.6 patch] i386: always use 4k stacks
- Previous by thread: Re: mmap over nfs leads to excessive system load
- Next by thread: Re: mmap over nfs leads to excessive system load
- Index(es):