Re: [PATCH 1/7] PCI Error Recovery: header file patch

On Tue, Nov 08, 2005 at 04:11:58PM -0800, Stephen Hemminger wrote:
> 
> >  
> > +/** The pci_channel state describes connectivity between the CPU and
> > + *  the pci device.  If some PCI bus between here and the pci device
> > + *  has crashed or locked up, this info is reflected here.
> > + */
> > +typedef int __bitwise pci_channel_state_t;
> 
> Bit operations should be on unsigned not signed value.

Agreed.  I'll wait for Linas to respin these.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/7] PCI Error Recovery
    • From: linas <[email protected]>
  • [PATCH 1/7] PCI Error Recovery: header file patch
    • From: linas <[email protected]>
  • Re: [PATCH 1/7] PCI Error Recovery: header file patch
    • From: Stephen Hemminger <[email protected]>

• Prev by Date: Re: [PATCH 0/12] FS-Cache: Generic filesystem caching facility
• Next by Date: Re: Database regression due to scheduler changes ?
• Previous by thread: Re: [PATCH 1/7] PCI Error Recovery: header file patch
• Next by thread: Re: [PATCH 1/7] PCI Error Recovery: header file patch
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]