Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display

Benjamin Herrenschmidt wrote:
> On Sat, 2005-11-12 at 07:28 +0800, Antonino A. Daplas wrote:
>> nvidiafb_pan_display() is incorrectly using the fields in
>> info->var instead of var passed to the function.
> 
> Shouldn't it also update info->var is is this done by the core ?
> 

Nobody calls or should call fbops->fb_pan_display() directly except
the wrapper fb_pan_display() in fbmem.c.  It already does the checking
and the update to info->var. So checking and updating for the offsets
will be redundant.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.14-mm2
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.14-mm2
    • From: Michal Piotrowski <[email protected]>
  • Re: 2.6.14-mm2
    • From: Andrew Morton <[email protected]>
  • [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
• Next by Date: Re: 2.6.14-mm2 OOPS - packet writing
• Previous by thread: Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
• Next by thread: Re: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]