Re: [PATCH 6/9] Cleanup kmem_cache_create()

On Friday 11 November 2005 01:04, Matthew Dobson wrote:
> - if (size < 4096 || fls(size - 1) == fls(size - 1 + 3 * BYTES_PER_WORD))
> + if (size < RED_ZONE_LIMIT ||
> +	fls(size - 1) == fls(size - 1 + 3 * BYTES_PER_WORD))
>              flags |= SLAB_RED_ZONE|SLAB_STORE_USER;

I would suggest sth. like

if (size < RED_TONE_LIMIT
    || fls(size - 1) = fls(size - 1 + 3 * BYTES_PER_WORD))
	flags |= SLAB_RED_ZONE | SLAB_STORE_USER


Reason: A binary operator in front is a huge hint 
	that this is a continued line.

Just compare when you go to a store next time.

	1
+	2
-	3
*	4

is much more readable then

1	+
2	-
3	*
4

right?


Regards

Ingo Oeser

Attachment: pgpWm7MrDlAQT.pgp
Description: PGP signature

---

• Follow-Ups:
  • Re: [PATCH 6/9] Cleanup kmem_cache_create()
    • From: Matthew Dobson <[email protected]>

• References:
  • [PATCH 0/9] Cleanup mm/slab.c v2
    • From: Matthew Dobson <[email protected]>
  • [PATCH 6/9] Cleanup kmem_cache_create()
    • From: Matthew Dobson <[email protected]>

• Prev by Date: [patch 2.6.14-git] SPI core, refresh
• Next by Date: Re: IO-APIC problem with 2.6.14-rt9
• Previous by thread: [PATCH 6/9] Cleanup kmem_cache_create()
• Next by thread: Re: [PATCH 6/9] Cleanup kmem_cache_create()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]