On 10 Nov 2005, at 5:40, Neil Brown wrote:
Thanks for the trace. I see what is happening. I changed wait_event_timeout_interruptible in md.c(md_thread) to wait_event_timeout as the thread no longer needs to be able to respond the signals. However that has the side-effect of putting the process in the 'D' state and adding to the 'uptime'. I guess I'll put that back... NeilBrown Signed-off-by: Neil Brown <[email protected]> ### Diffstat output ./drivers/md/md.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff ./drivers/md/md.c~current~ ./drivers/md/md.c --- ./drivers/md/md.c~current~ 2005-11-10 16:39:04.000000000 +1100 +++ ./drivers/md/md.c 2005-11-10 16:39:28.000000000 +1100 @@ -3439,10 +3439,11 @@ static int md_thread(void * arg) allow_signal(SIGKILL); while (!kthread_should_stop()) { - wait_event_timeout(thread->wqueue, - test_bit(THREAD_WAKEUP, &thread->flags) - || kthread_should_stop(), - thread->timeout); + wait_event_timeout_interruptible + (thread->wqueue, + test_bit(THREAD_WAKEUP, &thread->flags) + || kthread_should_stop(), + thread->timeout); try_to_freeze(); clear_bit(THREAD_WAKEUP, &thread->flags);
Sounds about right but... drivers/md/md.c: In function `md_thread':drivers/md/md.c:3441: warning: implicit declaration of function `wait_event_timeout_interruptible'
[...] LD .tmp_vmlinux1 drivers/built-in.o(.text+0x9904f): In function `md_thread': : undefined reference to `wait_event_timeout_interruptible' drivers/built-in.o(.text+0x9908f): In function `md_thread': : undefined reference to `wait_event_timeout_interruptible' make: *** [.tmp_vmlinux1] Error 1 HTH, Chris -- Chris Boot [email protected] http://www.bootc.net/
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
- Follow-Ups:
- Re: 2.6.14-mm1 RAID-1 in D< state
- From: Neil Brown <[email protected]>
- Re: 2.6.14-mm1 RAID-1 in D< state
- References:
- 2.6.14-mm1 RAID-1 in D< state
- From: Chris Boot <[email protected]>
- Re: 2.6.14-mm1 RAID-1 in D< state
- From: Neil Brown <[email protected]>
- Re: 2.6.14-mm1 RAID-1 in D< state
- From: Chris Boot <[email protected]>
- Re: 2.6.14-mm1 RAID-1 in D< state
- From: Neil Brown <[email protected]>
- 2.6.14-mm1 RAID-1 in D< state
- Prev by Date: Re: [patch] Cleanup bootmem allocator and fix alloc_bootmem_low
- Next by Date: Re: 2.6.14-mm1 RAID-1 in D< state
- Previous by thread: Re: 2.6.14-mm1 RAID-1 in D< state
- Next by thread: Re: 2.6.14-mm1 RAID-1 in D< state
- Index(es):
 |