On Thu, Sep 29, 2005 at 03:05:10AM +0100, Al Viro wrote:
> On Wed, Sep 28, 2005 at 06:41:06PM -0700, Andrew Morton wrote:
>
> > http://www.spinics.net/lists/kernel/msg399680.html
>
> Ewww... A lot of chunks consisting only of whitespace removals - great
> way to make patch less readable...
>
> And yes, that second call of sx_request_io_range() must die. BTW,
> what's wrong with use of mdelay() instead of that sx_long_delay()
> junk? Replacing both calls of sx_long_delay() with mdelay(50) would do it...
Trust me: mdelay didn't exist when I wrote that.
The code calls the private function that does what I think should've
been kernel infrastructure all along to make it easy to either:
change the body of the function to call the new infrastructure, or
replace the call of the private function with the call to the new
infrastructure.
Roger.
--
** [email protected] ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
Does it sit on the couch all day? Is it unemployed? Please be specific!
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |