Re: [PATCH] remove check_region in drivers-char-specialix.c

On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote:
> Hi Andrew,
> 
>    This is also a pretty simple case. We remove the wrapper and make
>    sx__request_io_range return struct resource *. We check its value accordingly
>    in the probing routine. It compiles cleanly here.

NAK.  You've just introduced a pile of leaks - if sx_probe() fails after
that call, you end up with region claimed and not released.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] remove check_region in drivers-char-specialix.c
    • From: Borislav Petkov <[email protected]>

• References:
  • [PATCH] remove check_region in drivers-char-specialix.c
    • From: Borislav Petkov <[email protected]>

• Prev by Date: Re: Infinite interrupt loop, INTSTAT = 0
• Next by Date: Re: [PATCH] cpuset read past eof memory leak fix
• Previous by thread: [PATCH] remove check_region in drivers-char-specialix.c
• Next by thread: Re: [PATCH] remove check_region in drivers-char-specialix.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]