[PATCH] 2.6.13-rc1 get_request nastiness

get_request is now expected to be holding on to queue_lock, with interrupts
disabled, when it returns NULL; but one path forgot that, causing all kinds
of nastiness under swap load - badness backtraces, strange failures, BUGs.

Signed-off-by: Hugh Dickins <[email protected]>

--- 2.6.13-rc1/drivers/block/ll_rw_blk.c	2005-06-29 11:54:08.000000000 +0100
+++ linux/drivers/block/ll_rw_blk.c	2005-06-29 14:41:04.000000000 +0100
@@ -1917,10 +1917,9 @@ get_rq:
 	 * limit of requests, otherwise we could have thousands of requests
 	 * allocated with any setting of ->nr_requests
 	 */
-	if (rl->count[rw] >= (3 * q->nr_requests / 2)) {
-		spin_unlock_irq(q->queue_lock);
+	if (rl->count[rw] >= (3 * q->nr_requests / 2))
 		goto out;
-	}
+
 	rl->count[rw]++;
 	rl->starved[rw] = 0;
 	if (rl->count[rw] >= queue_congestion_on_threshold(q))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] 2.6.13-rc1 get_request nastiness
    • From: Jens Axboe <[email protected]>

• Prev by Date: [1.] One line summary of the problem: When I call "halt", on my "Toshiba Tecra S2-128", the laptop won't actualy shutdown power. I *guess* this is an IRQ or/and ACPI problem. [2.] Full description of the problem/report: Hello, I knew I would have some trouble to make an un-tested laptop to work with GNU/Linux, but hope I recently reached enough skills to try it. I am totaly new to this mailing list. I know about computers, but not much about the Linux kernel at all. Here is a summary of what is working and not working: 1-The GNU/Linux console with framebuffer is perfectly working. 2-The wired network is working only most of the time. But in some conditions, like staring X seem to make it unstable. 3-Xorg is not working, almost all the time. Without changing anything related to the driver or the modules, it sometimes work or don't work. I could not figure out what is related to this. 4-"acpi_power_off" is not working either. At some random times of my installs, it did happen to work. But at each time it worked, at the next boot, it would not work. I have made all the "cat" of this mail in the same boot session, just in case. I don't know enough, but I fear some things about IRQ I don't know about would behave differrently on one boot or another. I am running with the latest gentoo kernel. Currently 2.6.11-gentoo-r11 I have tried the vanilla sources, but I could not make the framebuffer to work with them. I can make other tries if this can help. [3.] Keywords: IRQ, ACPI, Xorg, acpi_power_off, DSDT [4.] Kernel version (from /proc/version):
• Next by Date: Re: kmalloc without GFP_xxx?
• Previous by thread: [1.] One line summary of the problem: When I call "halt", on my "Toshiba Tecra S2-128", the laptop won't actualy shutdown power. I *guess* this is an IRQ or/and ACPI problem. [2.] Full description of the problem/report: Hello, I knew I would have some trouble to make an un-tested laptop to work with GNU/Linux, but hope I recently reached enough skills to try it. I am totaly new to this mailing list. I know about computers, but not much about the Linux kernel at all. Here is a summary of what is working and not working: 1-The GNU/Linux console with framebuffer is perfectly working. 2-The wired network is working only most of the time. But in some conditions, like staring X seem to make it unstable. 3-Xorg is not working, almost all the time. Without changing anything related to the driver or the modules, it sometimes work or don't work. I could not figure out what is related to this. 4-"acpi_power_off" is not working either. At some random times of my installs, it did happen to work. But at each time it worked, at the next boot, it would not work. I have made all the "cat" of this mail in the same boot session, just in case. I don't know enough, but I fear some things about IRQ I don't know about would behave differrently on one boot or another. I am running with the latest gentoo kernel. Currently 2.6.11-gentoo-r11 I have tried the vanilla sources, but I could not make the framebuffer to work with them. I can make other tries if this can help. [3.] Keywords: IRQ, ACPI, Xorg, acpi_power_off, DSDT [4.] Kernel version (from /proc/version):
• Next by thread: Re: [PATCH] 2.6.13-rc1 get_request nastiness
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]