Re: [PATCH 1/13]: PCI Err: pci.h header file changes

On Tue, Jun 28, 2005 at 06:58:17PM -0500, Linas Vepstas wrote:
> @@ -673,6 +704,7 @@ struct pci_driver {
>  	int  (*enable_wake) (struct pci_dev *dev, pci_power_t state, int enable);   /* Enable wake event */
>  	void (*shutdown) (struct pci_dev *dev);
>  
> +	struct pci_error_handlers err_handler;
>  	struct device_driver	driver;
>  	struct pci_dynids dynids;
>  };

Shouldn't that be a pointer and not the whole structure?  Wouldn't that
make it easier to "reuse" error handlers?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/13]: PCI Err: pci.h header file changes
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH 1/13]: PCI Err: pci.h header file changes
    • From: Linas Vepstas <[email protected]>

• Prev by Date: [PATCH 3/3] openfirmware: implement hotplug for macio devices
• Next by Date: [PATCH 1/13]: PCI Err: pci.h header file changes
• Previous by thread: [PATCH 1/13]: PCI Err: pci.h header file changes
• Next by thread: Re: [PATCH 1/13]: PCI Err: pci.h header file changes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]