Hi Chris, all,
> -stable review patch. If anyone has any objections, please let us
> know.
I have. This one patch is rather big and parts of it don't seem to
belong to -stable. Can't it be simplified? More below.
> Return to previous held-logic of calling scsi_add_host() only
> after the board has been completely initialized.
What real bug is it supposed to fix? (I guess some, but this leading
comment should give the datails.)
> Also return pci_*() error-codes during probe failure paths.
How does this belong to stable please? I don't see this fixing any
critical bug.
> This also corrects an issue where only lun 0 is being scanned for
> a given port.
This OTOH is probably OK.
> - if (ret != 0) {
> - goto probe_alloc_failed;
> - }
> + if (ret)
> + goto probe_failed;
This change can be made smaller.
> - if (ret != 0) {
> + if (ret) {
This aint -stable material.
Thanks,
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
