Re: [DVB patch 21/51] ttusb-dec: kfree cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Stezenbach <[email protected]> wrote:
>
> From: Adrian Bunk <[email protected]>
> 
> The Coverity checker discovered that these two kfree's can never be
> executed.
> 

That's a bit strange - the code was OK beforehand.  It's a bit of a tossup.

>  
>  	/* allocate memory for the internal state */
>  	state = (struct ttusbdecfe_state*) kmalloc(sizeof(struct ttusbdecfe_state), GFP_KERNEL);

This typecast is unneeded btw.  We tend to avoid casts to and from void*
because they defeat typechecking and uglify things.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux