On Sat, Jun 25, 2005 at 10:47:25AM +0100, Russell King wrote:
> On Thu, Jun 23, 2005 at 02:23:35PM +0100, Russell King wrote:
> > +What: register_serial/unregister_serial
> > +When: December 2005
> > +Why: This interface does not allow serial ports to be registered against
> > + a struct device, and as such does not allow correct power management
> > + of such ports. 8250-based ports should use serial8250_register_port
> > + and serial8250_unregister_port instead.
> > +Who: Russell King <[email protected]>
>
> Other places appear to have a prototype for these functions but do not
> use them:
>
> arch/xtensa/platform-iss/console.c:int register_serial(struct serial_struct*);
> arch/xtensa/platform-iss/console.c:void unregister_serial(int);
> drivers/char/amiserial.c:int register_serial(struct serial_struct *req);
> drivers/char/amiserial.c:void unregister_serial(int line);
>
> The patch which follows this message will remove these.
>
>
> In terms of the use of these functions, this is the state of play as of
> yesterday:
>
> arch/frv/kernel/setup.c:// register_serial(&__frv_uart0);
> arch/frv/kernel/setup.c:// register_serial(&__frv_uart1);
I've also removed this. The following is mostly for comment only.
I'm intending to commit this change by Monday at the latest.
[PATCH] Serial: remove unnecessary register_serial/unregister_serial
A couple of drivers declare register_serial/unregister_serial
prototypes but don't use them. FRV contains a commented out
call to register_serial. Since these are deprecated, remove
these unnecessary references.
Signed-off-by: Russell King <[email protected]>
Index: arch/frv/kernel/setup.c
===================================================================
--- 39040c7a05edd69381c0a25636a1a328d856cb9c/arch/frv/kernel/setup.c (mode:100644)
+++ uncommitted/arch/frv/kernel/setup.c (mode:100644)
@@ -790,12 +790,10 @@
#ifndef CONFIG_GDBSTUB_UART0
__reg(UART0_BASE + UART_IER * 8) = 0;
early_serial_setup(&__frv_uart0);
-// register_serial(&__frv_uart0);
#endif
#ifndef CONFIG_GDBSTUB_UART1
__reg(UART1_BASE + UART_IER * 8) = 0;
early_serial_setup(&__frv_uart1);
-// register_serial(&__frv_uart1);
#endif
#if defined(CONFIG_CHR_DEV_FLASH) || defined(CONFIG_BLK_DEV_FLASH)
Index: arch/xtensa/platform-iss/console.c
===================================================================
--- 39040c7a05edd69381c0a25636a1a328d856cb9c/arch/xtensa/platform-iss/console.c (mode:100644)
+++ uncommitted/arch/xtensa/platform-iss/console.c (mode:100644)
@@ -198,9 +198,6 @@
}
-int register_serial(struct serial_struct*);
-void unregister_serial(int);
-
static struct tty_operations serial_ops = {
.open = rs_open,
.close = rs_close,
Index: drivers/char/amiserial.c
===================================================================
--- 39040c7a05edd69381c0a25636a1a328d856cb9c/drivers/char/amiserial.c (mode:100644)
+++ uncommitted/drivers/char/amiserial.c (mode:100644)
@@ -1973,10 +1973,6 @@
}
-int register_serial(struct serial_struct *req);
-void unregister_serial(int line);
-
-
static struct tty_operations serial_ops = {
.open = rs_open,
.close = rs_close,
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
