Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions

Hello,

Jeff Garzik wrote:

Linux Kernel Mailing List wrote:

tree da7e51e7204625f21371eac23a931f4fe479e9db
parent 9e87545f06930c1d294423a8091d1077e7444a47

author Markus Lidel <[email protected]> Fri, 24 Jun 2005 12:02:23 -0700 committer Linus Torvalds <[email protected]> Fri, 24 Jun 2005 14:05:29 -0700 [PATCH] I2O: Lindent run and replacement of printk through osm printing functions Lindent run and replaced printk() through the corresponding osm_*() function

Please don't combine ANY code changes with an Lindent patch.

Also if there is no functional change, only cosmetical (the osm_*() function just mappes to printk(*, ...))?

Also, you typically want to do a pass through the post-Lindent code, to fix crazy word-wrapped lines like

                 if (copy_from_user

- (p->virt, (void __user *)(unsigned long)sg[i].addr_bus,

-                     sg_size)) {
+                    (p->virt,
+                     (void __user *)(unsigned long)sg[i].
+                     addr_bus, sg_size)) {
                     printk(KERN_DEBUG
                            "%s: Could not copy SG buf %d FROM user\n",
                            c->name, i);

OK, next time i do this too (i've not touched it, because i only have a 80x24 terminal and it was more readable after the Lindent run for me :-D)...

Thank you very much!


Best regards,


Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11

E-Mail: [email protected]
URL:    http://www.shadowconnect.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions
    • From: Jeff Garzik <[email protected]>

• References:
  • Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: reiser4 plugins
• Next by Date: Re: Mercurial vs Updated git HOWTO for kernel hackers
• Previous by thread: Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions
• Next by thread: Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]