On Thu, Jun 23, 2005 at 09:30:41AM -0700, Tim Bird wrote:
> >> While we are at it, what about changing this string to something
> >> language-neutral, like this:
> >>
> >> diff -Naurdp a/arch/i386/boot/compressed/misc.c b/arch/i386/boot/compressed/misc.c
> >> --- a/arch/i386/boot/compressed/misc.c 2004-04-04 05:37:23.000000000 +0200
> >> +++ b/arch/i386/boot/compressed/misc.c 2004-05-09 23:18:06.000000000 +0200
> >> @@ -10,6 +10,7 @@
> >> */
> >>
> >> #include <linux/linkage.h>
> >> +#include <linux/version.h>
> >> #include <linux/vmalloc.h>
> >> #include <linux/tty.h>
> >> #include <video/edid.h>
> >> @@ -373,9 +374,9 @@ asmlinkage int decompress_kernel(struct
> >> else setup_output_buffer_if_we_run_high(mv);
> >>
> >> makecrc();
> >> - putstr("Uncompressing Linux... ");
> >> + putstr("Linux " UTS_RELEASE);
> >> gunzip();
> >> - putstr("Ok, booting the kernel.\n");
> >> + putstr("\n");
> >> if (high_loaded) close_output_buffer_if_we_run_high(mv);
> >> return high_loaded;
> >> }
>
>
> Language neutrality is not a goal for kernel messages,
> that I'm aware of.
Of course this is true, but I think this very one is an exception: this
is the only one seen when booting with the "quiet" kernel option or
using some shiny bootlogo patches, both of which is common practice
among distribution-shipped kernels.
> I disagree with this change because
> it yields a net reduction in understanding what's going
> on during booting.
No, it does not yields any reduction. Only the strings itself are
changed, not the time they are printed.
Besides, nobody is interested that actually an uncompress step is in
progress, that just works. And, btw if it fails (the gunzip), it prints
an error message anyway iirc.
--
pozsy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
