Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.

On Wed, Jun 22, 2005 at 09:11:02AM +0100, Christoph Hellwig wrote:
> > +struct device * bus_find_device(struct bus_type * bus, struct device * start,
> > +				void * data, int (*match)(struct device *, void *))
> > +{
> > +	struct klist_iter i;
> > +	struct device * dev;
> > +
> > +	if (!bus)
> > +		return NULL;
> > +
> > +	klist_iter_init_node(&bus->klist_devices, &i,
> > +			     (start ? &start->knode_bus : NULL));
> > +	while ((dev = next_device(&i)))
> > +		if (match(dev, data))
> > +			break;
> > +	klist_iter_exit(&i);
> > +	return dev;
> 
> does the klist magic somehow grab a reference for you?

No, see my previous comment about the need for this to be fixed for
these two functions.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
    • From: Martin Schwidefsky <[email protected]>
  • Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
• Next by Date: reboo(RB_HALT_SYSTEM) / exiting init?
• Previous by thread: Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
• Next by thread: Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]