Pierre Ossman writes:
> GCC 4 checks the signedness of pointer casts and generates a whole bunch
> of warnings for code in scripts/ (which makes heavy use of signed char
> strings).
>
> This patch adds explicit casts.
This is way ugly. The _real_ bug is that someone decided to store
plain text pointers in "signed char*" variables. s/signed char/char/g
should be a much better fix.
> Signed-off-by: Pierre Ossman <[email protected]>
> Index: linux-wbsd/scripts/basic/fixdep.c
> ===================================================================
> --- linux-wbsd/scripts/basic/fixdep.c (revision 134)
> +++ linux-wbsd/scripts/basic/fixdep.c (working copy)
> @@ -242,7 +242,7 @@
> continue;
>
> found:
> - use_config(p+7, q-p-7);
> + use_config((char*)p+7, q-p-7);
> }
> }
>
> @@ -296,7 +296,7 @@
> signed char *p;
> char s[PATH_MAX];
>
> - p = strchr(m, ':');
> + p = (signed char*)strchr((char*)m, ':');
Clearly this is not the way to do text processing in C.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
