On Thu, 26 May 2005, Al Viro wrote:
> On Thu, May 26, 2005 at 09:21:46AM +0300, Pekka J Enberg wrote:
> > On Wed, 2005-05-25 at 22:10 +0100, Anton Altaparmakov wrote:
> > >This is not. memset(0) is not the same as = NULL IMO. I don't care if
> > >the compiler thinks it is the same. NULL does not have to be 0 so I
> > >prefer to initialize pointers explicitly to NULL. Even more so since this
> > >code is not performance critical at all so I prefer clarity here.
> >
> > I kind of figured out you were doing it on purpose. The fact is, NULL is
> > zero on _all_ Linux architectures. If it weren't, we'd have a lot of broken
> > code. Let me play the devils advocate here: why do you memset() (now
> > kcalloc()) in the first place?
>
> Oh, come on...
>
> ictx = kmalloc(sizeof(ntfs_index_context), GFP_NOFS);
> if (ictx)
> *ictx = (ntfs_index_context){.idx_ni = idx_ni};
> return ictx;
>
> and be done with that. Let compiler do its job. And yes, that *will*
> give properly initialized pointers even for weird platforms. Not that
> we had the slightest chance of porting to any of them...
Oh, cool. I didn't think gcc-2.95 did this but I just tried it with
2.95.2 and it worked.
Thanks,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
