[PATCH] Fix IPMI watchdog so the device can be reopened on an unexpected close

If there is an unexpected close, still allow the watchdog
interface to be re-opened on the IPMI watchdog.

Signed-off-by: Corey Minyard <[email protected]>

Index: linux-2.6.10/drivers/char/ipmi/ipmi_watchdog.c
===================================================================
--- linux-2.6.10.orig/drivers/char/ipmi/ipmi_watchdog.c
+++ linux-2.6.10/drivers/char/ipmi/ipmi_watchdog.c
@@ -723,11 +723,11 @@
 		if (expect_close == 42) {
 			ipmi_watchdog_state = WDOG_TIMEOUT_NONE;
 			ipmi_set_timeout(IPMI_SET_TIMEOUT_NO_HB);
-			clear_bit(0, &ipmi_wdog_open);
 		} else {
 			printk(KERN_CRIT PFX "Unexpected close, not stopping watchdog!\n");
 			ipmi_heartbeat();
 		}
+		clear_bit(0, &ipmi_wdog_open);
 	}
 
 	ipmi_fasync (-1, filep, 0);

---

• Prev by Date: Re: which ioctls matter across filesystems
• Next by Date: [PATCH] Fix a deadlock in the IPMI driver
• Previous by thread: [RFC] non resident page management, #4
• Next by thread: [PATCH] Fix a deadlock in the IPMI driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]