On Wed, 2005-04-27 at 20:46, OGAWA Hirofumi wrote:
> Badari Pulavarty <[email protected]> writes:
>
> > Hi,
> >
> > I answered my own question. It looks like we could have pages
> > with buffers without page->mapping. In such cases, we shouldn't
> > de-ref page->mapping in drop_buffers(). Here is the trivial
> > patch to fix it.
> >
> > Thanks,
> > Badari
>
> [...]
>
> >
> > Signed-off-by: Badari Pulavarty <[email protected]>
> > --- linux-2.6.12-rc2.org/fs/buffer.c 2005-04-27 07:19:44.000000000 -0700
> > +++ linux-2.6.12-rc2/fs/buffer.c 2005-04-27 07:20:34.000000000 -0700
> > @@ -2917,7 +2917,7 @@ drop_buffers(struct page *page, struct b
> >
> > bh = head;
> > do {
> > - if (buffer_write_io_error(bh))
> > + if (buffer_write_io_error(bh) && page->mapping)
> > set_bit(AS_EIO, &page->mapping->flags);
> > if (buffer_busy(bh))
> > goto failed;
>
> On my experience, this happened the bh leak case only.
Could you explain more on bh leak ? Is there one in the current code ?
>
> If you are not sure whether this is valid state or not, I worry this
> patch hides real bug. How about adding the warning, not just remove
> de-ref?
Andrew confirmed that this is a valid case.
I don't understand what you want to do here ? If the mapping is NULL,
we can't de-ref it. Whats the point in putting a warning and de-refing
it. Its going to cause NULL pointer de-ref anyway.
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
